feat: Introduce Amazon Linux 2023 ARM image #4780
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimamo5
changed the title
dimamo5
force-pushed
the
amazon-linux-2023-arm
branch
from
c9ca410 to
3d30fc0
Compare
|
To me the example looks similar to al2023 for x64. Images are just an example and not tested at all. I have no issue with adding another example. But would it not be possible to make the al2023 more generic and just inject the architecture? Any thoughts? |
Made these changes in the latest commits. Seems to be working well in both architectures. |
|
@npalm when you have some free time, could you take a look? |
npalm
reviewed
Oct 3, 2025
| ## install the runner | ||
|
|
||
| s3_location=${S3_LOCATION_RUNNER_DISTRIBUTION} | ||
| architecture=${RUNNER_ARCHITECTURE} |
There was a problem hiding this comment.
What is the reason of removing this variable? Is it not used?
|
Thx for the PR, will not be able to able to get the PR merged in the next weeks. I will catch up end of the month. Sorry for tthe delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to introduce a new AMI for Amazon Linux 2023 in the ARM 64 architecture. I took a similar approach to what was done for Ubuntu Jammy where the code is duplicated into a new Packer directory. I'm also open to parameterize the runner architecture and have a single Packer configuration.